fix: use ngx.null for nil check on null map values #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, whenever a map containing some nil values is passed to the process_auto_fields function, the code fails to recognize it applying the wrong logic to it. This commit makes sure this doesn't happen by performing the nil check on `ngx.null` instead of `nil`.
mikefero
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, whenever a map containing some nil values is passed
to the process_auto_fields function, the code fails to
recognize it applying the wrong logic to it.
This commit makes sure this doesn't happen by performing the
nil check on
ngx.nullinstead ofnil.