fix: ensure string auto fields can be generated #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where the value for an auto generate string is either ngx.null or nil which have two different meaning in goks as OpenResty is not used.
|
Can we add a test for this? |
GGabriele
previously approved these changes
Jul 23, 2022
|
Added a test; once approved the entire PR can be squashed and a new version of goks can be generated. |
To make validation easier for ngx.now, the golang ngx.now package has separated out the function that processes the Lua function.
mikefero
force-pushed
the
fix/string-auto-field
branch
from
9dfc365
to
d537068
Compare
GGabriele
approved these changes
Jul 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the value for an auto generate string is either ngx.null or nil which have two different meaning in goks as OpenResty is not used.