Add JSON Schema validation to Lua #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the reason for not being able to use the Lua library for this? Is it using a dynamic shared object? |
from a quick review of ljsonschema, i saw:
|
hbagdi
reviewed
Aug 16, 2022
lualibs/go/jsonschema/api.go
Outdated
|
|
||
| func unmarshal(s string) (interface{}, error) { | ||
| decoder := json.NewDecoder(strings.NewReader(s)) | ||
| decoder.UseNumber() |
There was a problem hiding this comment.
Why is this being done? Does Lua's cjson decode numbers as string?
There was a problem hiding this comment.
copy/pasta error.
hbagdi
reviewed
Aug 16, 2022
lualibs/go/jsonschema/api.go
Outdated
| if err := decoder.Decode(&doc); err != nil { | ||
| return nil, err | ||
| } | ||
| if t, _ := decoder.Token(); t != nil { |
There was a problem hiding this comment.
Should this not always return an error == io.EOF?
There was a problem hiding this comment.
yes, we're expecting a nil response. i'll change to check that the error is actually io.EOF
hbagdi
reviewed
Aug 16, 2022
|
|
||
| l.Push(lua.LFalse) | ||
| l.Push(lua.LString(err.Error())) | ||
| } |
There was a problem hiding this comment.
Is the code missing a return here?
New 'go.jsonschema' module, exports two functions: compile( <schematext> [, <draftname>] ) Where <schematext> is a string containing a JSONSchema and <draftname> is one of "draft4", "draft6", "draft7", "draft2019" or "draft2020". If omitted, "draft4" is assumed. If successful, a compiled schema object will be returned, on error it returns nil and an error message. validate( <schema>, <input> ) Where <schema> is a compiled schema object and <input> is some JSON text. If succesful, returns a single true value. If the validation failes, returns false and a descriptive error. On any other error, returns nil and an error message.
javierguerragiraldez
force-pushed
the
feat/jsonschema-validation
branch
from
195f065
to
e9f787f
Compare
javierguerragiraldez
force-pushed
the
feat/jsonschema-validation
branch
from
e9f787f
to
aa26d42
Compare
hbagdi
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New 'go.jsonschema' module, exports two functions:
compile( <schematext> [, <draftname>] )Where
<schematext>is a string containing a JSONSchema and<draftname>is one of "draft4", "draft6", "draft7", "draft2019" or "draft2020".
If omitted, "draft4" is assumed.
If successful, a compiled schema object will be returned, on error it
returns nil and an error message.
validate( <schema>, <input> )Where
<schema>is a compiled schema object and<input>is some JSONtext.
If succesful, returns a single true value. If the validation failes,
returns false and a descriptive error. On any other error, returns nil
and an error message.