Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove all Lua lib and bin files from Kong Gateway installation #30

Merged
merged 3 commits into from
Sep 14, 2022

Conversation

mikefero
Copy link
Contributor

This removes lua-tree/bin and lua-tree/bin from the installation of the Kong Gateway; reducing the overall size of the goks library. .gitignore is also updated to ensure subsequent executions of make gen-lua-tree does not add any new bin/lib libraries into the lua-tree.

Note: This PR includes a 3rd commit which syncs up the patched files; or in this instance removes previous patching.

This removes lua-tree/bin and lua-tree/bin from the installation of the
Kong Gateway; reducing the overall size of the goks library.
This commit fixes up the patched Lua files and syncs the lua-tree. The
re-generation occurred due to changes with ngx.re<find.match> as they
are now bundled in with the loader using gluare.
@mikefero mikefero requested a review from a team as a code owner September 14, 2022 14:25
Copy link
Contributor

@javierguerragiraldez javierguerragiraldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, please!

@hbagdi hbagdi merged commit d40864c into main Sep 14, 2022
@hbagdi hbagdi deleted the chore/remove-shared-libraries branch September 14, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants