-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update yaml validation to match kong behavior #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if there is any upstream GitHub Issue on the yaml project about why this doesn't work with v3
but it does with v1
?
@omegabytes Please clean up the description in this PR to reflect this change. |
Should we standardize what we use for yaml across our different projects (if possible)? e.g. Kong/deck#800 |
I scanned the open + closed issues for go-yaml but didn't find a directly related issue. |
Strongly agree with standardizing, at least for yaml packages. Luckily downgrading to v1 was a simple fix (thanks @mikefero). I've also considered standing up complete unit testing that asserts that yaml handling has behavioral parity with kong's yaml handling. That's a big task so I'd like to avoid it unless absolutely necessary. We'd probably need pretty exhaustive unit tests in both kong and in goks (and in deck, and so on). |
Downgrades yaml package so that goks has behavioral parity with kong yaml validation.