chore: disable tag validation function #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tags validation is already occurring on the go side and gopher-lua does not properly handle ASCII (or extended ASCII) range expressions in the `string.match` implementation using gopher-lua/pm module.
mikefero
force-pushed
the
chore/disable-lua-tag-validation
branch
from
c1037d6
to
a08ca7e
Compare
hbagdi
reviewed
Feb 23, 2022
patches/lua-tree.patch
Outdated
| + -- end | ||
|
|
||
| return true | ||
| end |
There was a problem hiding this comment.
This function is considered part of the public interface that plugins can consume and hence I'm a bit hesitant to accept it.
If strings. the match is the root cause, is using the go.re2 module an option? That will still result in patch to this file, which is okay but it may be able to solve the problem for a wider base.
What do you think?
There was a problem hiding this comment.
Makes sense to me, I will experiment a bit on this and run some tests to make sure this is a viable option.
There was a problem hiding this comment.
Fixed up the code, but needs further testing; converting PR to draft for further evaluation.
|
#10 implements this correctly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tags validation is already occurring on the go side and gopher-lua does not properly handle ASCII (or extended ASCII) range expressions in the
string.matchimplementation using gopher-lua/pm module.