Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add aws-lambda plugin test case #9

Closed
wants to merge 1 commit into from
Closed

add aws-lambda plugin test case #9

wants to merge 1 commit into from

Conversation

GGabriele
Copy link
Contributor

No description provided.

@GGabriele GGabriele mentioned this pull request Mar 3, 2022
Merged
@GGabriele GGabriele marked this pull request as ready for review March 3, 2022 16:21
@GGabriele GGabriele requested a review from a team as a code owner March 3, 2022 16:21
@mikefero
Copy link
Contributor

mikefero commented Mar 3, 2022

I think this test should be moved to Koko in the validater_test::TestValidate() and close this PR.

My reasoning is we already have a generic custom_entity_check test in goks when a fix was applied in goks to handle the issue of the return not containing the message. If we needed to change the underlying source for the match regex case I would say then yes add this case here; I feel it is better served in Koko.

@GGabriele
Copy link
Contributor Author

Done Kong/koko@0ac922e

@GGabriele GGabriele closed this Mar 3, 2022
@hbagdi hbagdi deleted the aws_lambda_test branch June 21, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GGabriele @mikefero