Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't escape newlines in curl bodies #102

Merged
merged 2 commits into from May 4, 2019
Merged

Don't escape newlines in curl bodies #102

merged 2 commits into from May 4, 2019

Conversation

gschier
Copy link
Contributor

@gschier gschier commented Jul 25, 2017

Fixes #96

This PR removes the improper newline escaping that was done on generated Curl request bodies.

@gschier
Copy link
Contributor Author

gschier commented Jul 25, 2017

Hmm, the CI tests seem to be seriously broken. They all passed on my local machine FYI.

@RolphH
Copy link

RolphH commented Apr 12, 2018

Any change of having this fixed/merged?

@muzafarova
Copy link

Such a useful fix idea! Any chance of having this merged?

@kimmobrunfeldt
Copy link

@gschier thanks for the insomnia-httpsnippet fork! We're using it in our api documentation to fix this exact issue.

@gschier
Copy link
Contributor Author

gschier commented Jan 29, 2019

@kimmobrunfeldt you're welcome! We actually moved that repo into a mono repo so I'll be deleting that fork soon. Hopefully you forked my fork!

@darrenjennings
Copy link
Contributor

@gschier hello! 👋 I'm new to this project, and have begun some housecleaning... Would love to merge any work that has happened in the insomnia fork. Has it diverged greatly? If you have bandwidth I will be reviewing PR's, including this one.

@darrenjennings darrenjennings changed the base branch from master to next March 10, 2019 23:24
@gschier
Copy link
Contributor Author

gschier commented Mar 13, 2019

I think this is the only thing that's changed, besides merging in a couple of the stale PRs from here 😀

@darrenjennings
Copy link
Contributor

@gschier is now a maintainer of httpsnippet! Welcome! With your new maintainer abilities, feel free to rebase off master and I will gladly review. Looks good pending tests pass

@darrenjennings darrenjennings self-requested a review April 26, 2019 05:04
@darrenjennings
Copy link
Contributor

do our tests not capture this? wondering why we don't need to modify any output fixtures

@gschier
Copy link
Contributor Author

gschier commented May 3, 2019

Added a new multiline JSON test fixture to capture this

.gitignore Outdated
@@ -1,3 +1,4 @@
*.log
node_modules
coverage*
.idea
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's no include IDE specific files in favor of users just using their .gitignore_global

Suggested change
.idea

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I agree. I just learned about .gitignore_global a couple weeks ago, then promptly forgot about it 😆

@darrenjennings
Copy link
Contributor

just a small comment and then it's good to go.

@gschier gschier merged commit 9d223e3 into Kong:next May 4, 2019
@gschier gschier deleted the fix/curl-multiline-body branch May 4, 2019 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants