-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't escape newlines in curl bodies #102
Conversation
Hmm, the CI tests seem to be seriously broken. They all passed on my local machine FYI. |
Any change of having this fixed/merged? |
Such a useful fix idea! Any chance of having this merged? |
@gschier thanks for the insomnia-httpsnippet fork! We're using it in our api documentation to fix this exact issue. |
@kimmobrunfeldt you're welcome! We actually moved that repo into a mono repo so I'll be deleting that fork soon. Hopefully you forked my fork! |
@gschier hello! 👋 I'm new to this project, and have begun some housecleaning... Would love to merge any work that has happened in the insomnia fork. Has it diverged greatly? If you have bandwidth I will be reviewing PR's, including this one. |
I think this is the only thing that's changed, besides merging in a couple of the stale PRs from here 😀 |
@gschier is now a maintainer of httpsnippet! Welcome! With your new maintainer abilities, feel free to rebase off master and I will gladly review. Looks good pending tests pass |
do our tests not capture this? wondering why we don't need to modify any output fixtures |
Added a new multiline JSON test fixture to capture this |
.gitignore
Outdated
@@ -1,3 +1,4 @@ | |||
*.log | |||
node_modules | |||
coverage* | |||
.idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's no include IDE specific files in favor of users just using their .gitignore_global
.idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, I agree. I just learned about .gitignore_global
a couple weeks ago, then promptly forgot about it 😆
just a small comment and then it's good to go. |
Fixes #96
This PR removes the improper newline escaping that was done on generated Curl request bodies.