Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 405 HTTP status description #1479

Merged
merged 1 commit into from May 3, 2019
Merged

Conversation

@rafaelrenanpacheco
Copy link
Contributor

rafaelrenanpacheco commented May 3, 2019

The https://developer.mozilla.org/en-US/docs/Web/HTTP/Status page do say that the 405 should not be returned for GET and HEAD. But if you click on that 405 link it will open https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/405, and there there's nothing about mandatory methods.

On that page you will get the RFC link https://tools.ietf.org/html/rfc7231#section-6.5.5, and again, there's nothing about mandatory methods.

The restful documentation also doesn't talk about mandatory methods for 405: https://restfulapi.net/http-status-codes/

Spring Framework (a well know framework for Java) has some default configurations for the Spring Data Rest project that will result in GET requests returning 405.

Since the RFC should be the winner here, and the divergence between the mozilla's pages, I'm proposing this fix to remove the misleading description.

The https://developer.mozilla.org/en-US/docs/Web/HTTP/Status page do say that the 405 should not be returned for GET and HEAD. But if you click on that 405 link it will open https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/405 , and there there's nothing about mandatory methods.

On that page you will get the RFC link https://tools.ietf.org/html/rfc7231#section-6.5.5 , and again, there's nothing about mandatory methods.

The restful documentation also doesn't talk about mandatory methods for 405: https://restfulapi.net/http-status-codes/

Spring Framework (a well know framework for Java) has some configuration for the Spring Data Rest project that will result in GET requests returning 405.

Since the RFC should be the winner here, and the divergence between the mozilla's pages, I'm proposing this fix to remove the misleading description.
@gschier
gschier approved these changes May 3, 2019
Copy link
Contributor

gschier left a comment

I'm okay with this change

@gschier gschier merged commit fd9ebf3 into Kong:develop May 3, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rafaelrenanpacheco rafaelrenanpacheco deleted the rafaelrenanpacheco:patch-1 branch May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.