Fix 405 HTTP status description #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The https://developer.mozilla.org/en-US/docs/Web/HTTP/Status page do say that the 405 should not be returned for GET and HEAD. But if you click on that 405 link it will open https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/405 , and there there's nothing about mandatory methods. On that page you will get the RFC link https://tools.ietf.org/html/rfc7231#section-6.5.5 , and again, there's nothing about mandatory methods. The restful documentation also doesn't talk about mandatory methods for 405: https://restfulapi.net/http-status-codes/ Spring Framework (a well know framework for Java) has some configuration for the Spring Data Rest project that will result in GET requests returning 405. Since the RFC should be the winner here, and the divergence between the mozilla's pages, I'm proposing this fix to remove the misleading description.
gschier
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The https://developer.mozilla.org/en-US/docs/Web/HTTP/Status page do say that the 405 should not be returned for GET and HEAD. But if you click on that 405 link it will open https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/405, and there there's nothing about mandatory methods.
On that page you will get the RFC link https://tools.ietf.org/html/rfc7231#section-6.5.5, and again, there's nothing about mandatory methods.
The restful documentation also doesn't talk about mandatory methods for 405: https://restfulapi.net/http-status-codes/
Spring Framework (a well know framework for Java) has some default configurations for the Spring Data Rest project that will result in GET requests returning 405.
Since the RFC should be the winner here, and the divergence between the mozilla's pages, I'm proposing this fix to remove the misleading description.