Allow checkbox input type in prompt dialog #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
develohpanda
suggested changes
Mar 11, 2020
There was a problem hiding this comment.
Hi @superruzafa! Thanks for putting up this PR; LGTM! Just one suggestion regarding spacing, and then good to go!
In the future it would be nice to update the onComplete callback to accept the true type (boolean, integer, string), but this is good for now. 😃
superruzafa
commented
Mar 12, 2020
develohpanda
approved these changes
Mar 12, 2020
develohpanda
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the Prompt modal dialog to show
<input type="checkbox">elements.You only have to call it by setting
inputTypetocheckbox. You can also setdefaultValuetofalse/trueto uncheck/check the checkbox, respectively.The modal will return the string value
"true"if the the checkbox was checked and"false"otherwise.