Add support for OAuth2 to OpenAPI3 importer #2184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for insomnia-storybook ready! Built with commit 944b1b9 |
develohpanda
approved these changes
May 27, 2020
There was a problem hiding this comment.
Hi @sebastianjonasson, thanks for working on this! Apologies for the delay. 😞
I will add tests if you want me to proceed.
Code looks good! I will merge once these tests are in. 🤗
|
@develohpanda - Made some updates and added test. The pre-commit hook generated diffs in these files: are the meant to be commited? |
No they shouldn't be. Your branch is out of date with the develop, so if you merge with develop that should fix up the |
develohpanda
reviewed
Jun 3, 2020
develohpanda
approved these changes
Jun 6, 2020
develohpanda
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for including OAuth2 settings when importing a workspace from an OpenAPI3 file.
Parses
authorizationUrl,accessToken, andscopefrom OpenAPI specification file. Then adds templates/variables for user credentials (password,username,client_id,client_secret).I will add tests if you want me to proceed.
Closes #2183