Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update instructions for development on windows #3281

Closed
wants to merge 1 commit into from

Conversation

pchmn
Copy link

@pchmn pchmn commented Apr 13, 2021

In order to install node-libcurl dependency properly on windows, we need to have nasm installed.

If you don't have nasm, dependency is installed but not its bindings, so there will be an error when you start the app (an error about binding folder not existing in node_modules/node-libcurl package).
I found this on node-libcurl docs.

So I updated the doc to specify that you may need nasm when developing on windows.

@reynolek reynolek added C-improvement Category: Improvement / Enhancement O-windows Operating System: Windows labels Apr 22, 2021
@reynolek
Copy link
Contributor

Thanks for the PR @pchmn!

@develohpanda
Copy link
Contributor

Thanks for the PR @pchmn! Which branch were you trying to build from - master, develop, or another branch? We use pre-built binaries for node-libcurl and no longer build from source, so nasm shouldn't be required. The master branch is very out of date though and it's possible that branch still contains code before we switched to pre-build binaries.

@pchmn
Copy link
Author

pchmn commented Apr 30, 2021

I used the develop branch. I will retry with a fesh checkout of develop branch without nasm to see if I did something wrong before. I'll keep you updated.

@dimitropoulos
Copy link
Contributor

I just did this on windows recently and didn't have to do anything with nasm. If you have more information please let us know and we can reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-improvement Category: Improvement / Enhancement O-windows Operating System: Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants