Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Postman 2.1 Export (most but not all elements/cases) #3827

Closed
wants to merge 1 commit into from

Conversation

Vyoam
Copy link

@Vyoam Vyoam commented Jul 17, 2021

Closes #1156 (it was actually converted to a discussion, but this PR closes it properly)
Have discussed a bit with @dimitropoulos: Vyoam/InsomniaToPostmanFormat#4
Let's get this done. :)

Main notes:

  • Adds support for Postman 2.1 export; mostly based on https://github.com/Vyoam/InsomniaToPostmanFormat
  • Limitations listed here: [Improvement] Export collections using Postman format #3703 (comment)
  • See the individual files in the PR for specific notes
  • Verified import of the output json with Postman 8.8.0
  • Started on May 29; worked on and off; completed around Jul 18; Develop branch changes were merged on Jul 18
  • At one point, I did wonder if future changes in Insomnia's data structure will affect this export code. It might, but...
    1. this Postman export code simply uses the same object used for Insomnia's self export.
    2. any breaking change be easy to detect via the added UT.
    3. I guess har export code would anyway be updated in that situation, and this one can be done mostly along the same lines.

Copy link
Author

@Vyoam Vyoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking self-review as finished.

@Vyoam Vyoam changed the title Add support for Postman 2.1 Export (most but not all elements/cases) Add Support for Postman 2.1 Export (most but not all elements/cases) Jul 19, 2021
@Vyoam Vyoam marked this pull request as ready for review July 19, 2021 17:00
@Vyoam
Copy link
Author

Vyoam commented Jul 20, 2021

As I don't have access to request reviews, tagging a few folks I found in the merged PRs.
Just want to have this closed and let everyone start using it. :)
@dimitropoulos
@develohpanda
@reynolek
@wdawson
@DMarby

@develohpanda
Copy link
Contributor

develohpanda commented Jul 20, 2021

Hi @Vyoam! Thanks for this PR. I saw the draft PR a few days ago and kicked off some discussions internally and we feel this would be better suited as a standalone plugin rather than bundled with the app. You can maintain, release and update plugins on your own accord via NPM, and they will show on the plugin hub for users to install. There is some documentation here for creating plugins - specifically, the data context (though this is slightly out of date so I encourage you to double check with the plugin contexts' as implemented as well).

You can generate a basic plugin from Preferences > Plugins, and feel free to reach out if you need any help or advice when creating a plugin.

@Vyoam
Copy link
Author

Vyoam commented Jul 20, 2021

Thanks @develohpanda. I understand. Will try the plugin approach. Closing this.

@Vyoam Vyoam closed this Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Export collections using Postman format
2 participants