removes insomnia designer migration code #4404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitropoulos
force-pushed
the
feat/remove-migration
branch
from
cae26fc
to
18daf70
Compare
dimitropoulos
force-pushed
the
feat/remove-migration
branch
from
18daf70
to
d8d78f7
Compare
dimitropoulos
requested review from
develohpanda,
jackkav and
gatzjames
and removed request for
develohpanda
dimitropoulos
commented
Jan 25, 2022
Comment on lines
-76
to
-86
|
|
||
| if (!db && !appDataDir && !src) { | ||
| const designerDir = getAppDataDir('Insomnia Designer'); | ||
| db = await neDbAdapter(designerDir); | ||
| db && | ||
| logger.debug( | ||
| `Data store configured from Insomnia Designer app data directory at \`${path.resolve( | ||
| designerDir, | ||
| )}\``, | ||
| ); | ||
| } |
There was a problem hiding this comment.
@falondarville @wdawson I just want to make sure you're aware of this: it means that inso will also not have any knowledge of anything related to insomnia designer. It makes sense to remove here since literally all other mention of designer is being removed as well, but I just wanted to call it out since I don't think we'd talked about it prior.
dimitropoulos
force-pushed
the
feat/remove-migration
branch
from
43d05ed
to
55d7f83
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes INS-1311
changelog(Breaking Changes): We removed the ability to migrate from Insomnia Designer
This PR removes all functionality (or mention) of migration from Insomnia Designer from documentation, tests, source code, user settings, etc.