chore(deps) @jest/globals for insomnia #4798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise, I kept getting failed bootstraps because the rimraf commands were deleting incremental builds out-of-band of tsc
filfreire
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is simply a follow-up to #4793 which does exactly the same task, but for the insomnia package.
this is, therefore, ALMOST the final piece of the puzzle in the aim of removing the jest globals from our project. You see, for any project that doesn't include testing-library, it's now working as intended (no globals pollution).
If we remove the references to testing-library, then the
jestglobal go away.however for some reason I don't quite understand, the presence of the mocha types in the
insomnia-tesingpackage somehow manages to pollute the global type context for all other packages.