Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tests): support json schema validation #6532

Merged
merged 3 commits into from
Dec 6, 2023
Merged

feat(tests): support json schema validation #6532

merged 3 commits into from
Dec 6, 2023

Conversation

kobenguyent
Copy link
Contributor

@kobenguyent kobenguyent commented Sep 19, 2023 •
edited by gatzjames
Loading

Closes #6507

Screenshot 2023-09-19 at 13 55 48
Screenshot 2023-09-19 at 13 56 00

changelog(Improvements): Add support for json schema in unit tests

Closes INS-3325

@mirket999
Copy link

As I experienced, isn`t it supported to validate schema until your changes are merged?

@kobenguyent
Copy link
Contributor Author

As I experienced, isn`t it supported to validate schema until your changes are merged?

indeed @mirket999

@mirket999
Copy link

As I experienced, isn`t it supported to validate schema until your changes are merged?

indeed @mirket999
It is one of the core things in API testing. Hopefully your changes will be deployed soon and solve the issue.

@gatzjames gatzjames force-pushed the feat-support-json-schema-validation branch 2 times, most recently from 6fa08b9 to e63048e Compare November 14, 2023 19:49
@gatzjames gatzjames requested a review from a team November 14, 2023 19:50
@gatzjames gatzjames force-pushed the feat-support-json-schema-validation branch from afdfa9d to d2c1756 Compare November 15, 2023 13:03
@CLAassistant
Copy link

CLAassistant commented Nov 16, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gatzjames gatzjames force-pushed the feat-support-json-schema-validation branch from 8017182 to 168d79e Compare December 6, 2023 13:21
gatzjames
gatzjames approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@gatzjames gatzjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! 🚀
Updated a test to the inso smoke tests to make sure it works there too!

@gatzjames gatzjames self-assigned this Dec 6, 2023
@kobenguyent
Copy link
Contributor Author

Thanks for the contribution! 🚀 Updated a test to the inso smoke tests to make sure it works there too!

Thanks @gatzjames for the review!

filfreire
filfreire approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@filfreire filfreire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@filfreire filfreire merged commit 1d97689 into Kong:develop Dec 6, 2023
8 checks passed
@kobenguyent kobenguyent deleted the feat-support-json-schema-validation branch December 20, 2023 12:07
jackkav pushed a commit to jackkav/insomnia that referenced this pull request Mar 13, 2024
@kobenguyent @gatzjames @jackkav
feat(tests): support json schema validation (Kong#6532)
a020b85 
* feat(tests): support json schema validation

* add json schema to cli test

---------

Co-authored-by: gatzjames <jamesgatzos@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatzjames gatzjames gatzjames approved these changes

@filfreire filfreire filfreire approved these changes

Assignees

@gatzjames gatzjames

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kobenguyent @mirket999 @CLAassistant @filfreire @gatzjames