Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable collection-variable in pre-request scripting [INS-3379] #7122

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

ihexxa
Copy link
Contributor

@ihexxa ihexxa commented Feb 28, 2024

  • enable collection-variable in pre-request scripting
  • merge similar pre-request script test cases into one to improve performance

How to test:

Please run this script and check its output.

const { Variable, VariableList } = require('insomnia-collection');

const v1 = new Variable({key: "myVar1", value: "1"});
const v2 = new Variable({key: "myVar2", value: "2"});

const varList = new VariableList(Variable, [v1]);
varList.add(v2)

console.log(v1.toString());
console.log(varList.all());

@ihexxa ihexxa self-assigned this Feb 28, 2024
jackkav
jackkav previously approved these changes Feb 29, 2024
filfreire
filfreire previously approved these changes Feb 29, 2024
@jackkav jackkav dismissed stale reviews from filfreire and themself via 4443d70 February 29, 2024 13:31
@jackkav jackkav merged commit a15b09a into develop Feb 29, 2024
5 of 6 checks passed
@jackkav jackkav deleted the pre-script-col-var branch February 29, 2024 13:32
jackkav added a commit to jackkav/insomnia that referenced this pull request Mar 13, 2024
…ong#7122)

* chore: enable Headers in pre-request scripting

* feat: add Variables and VariableList to the collection

---------

Co-authored-by: Jack Kavanagh <jackkav@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants