set sort key on import #7148
Merged
set sort key on import #7148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filfreire
approved these changes
Mar 8, 2024
jackkav
force-pushed
the
fix/import-request-ordering
branch
from
3adf447
to
b1d057a
Compare
jackkav
added a commit
to jackkav/insomnia
that referenced
this pull request
Mar 13, 2024
* set sort key * use a snapshot test * reverse matcher * fix test snapshots * remove old outputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: using snapshot tests to improve dx when fixing import bugs
this implication is we don't need output fixtures anymore
potentially within this PR scope could be deleting those output files
closes INS-3598