support SSE method, request body and auth #7182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 15, 2024
jackkav
force-pushed
the
sse/add-auth-header
branch
from
3f41964
to
22b8318
Compare
marckong
reviewed
Mar 19, 2024
| @@ -87,6 +87,7 @@ interface OpenCurlRequestOptions { | |||
| workspaceId: string; | |||
| url: string; | |||
| headers: RequestHeader[]; | |||
| authHeader?: { name: string; value: string }; | |||
There was a problem hiding this comment.
I wonder if there is a specific signature for this.
marckong
approved these changes
Mar 19, 2024
gatzjames
approved these changes
Mar 19, 2024
ihexxa
reviewed
Mar 19, 2024
| @@ -142,11 +143,15 @@ const openCurlConnection = async ( | |||
| caCert: caCertificate, | |||
| certificates: filteredClientCertificates, | |||
| }); | |||
| // set method | |||
There was a problem hiding this comment.
nit: Probably we should consider to make this function to follow Open-Closed principle at some time to make it easier to maintain.
There was a problem hiding this comment.
I don't understand could you provide an example?
filfreire
approved these changes
Mar 19, 2024
jackkav
force-pushed
the
sse/add-auth-header
branch
from
22b8318
to
8d79e25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes INS-3606
closes INS-3624