Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: release-start [no-ticket] #7212

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

filfreire
Copy link
Member

@filfreire filfreire commented Mar 27, 2024

adds a workaround to handle weird botched releases (e.g. when we merge a beta release without running publish, which causes iterations to get a bit messy, due to that info not being added by npm workspaces version to the package lock, I think)

Example, currently if we just try to run beta release, it will default to beta.0 due to a previous mistake:
image

With this workaround we can force beta.2:
image

and then commit that version. Later if we would trigger, beta.3, we could go back to running npm --workspaces version --preid "beta" prerelease and it would get picked up correctly:
image

@filfreire filfreire requested a review from a team March 27, 2024 11:26
@filfreire filfreire merged commit ac3e38e into Kong:develop Mar 27, 2024
7 checks passed
@filfreire filfreire deleted the fix/release-start-weirdness branch March 27, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants