Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: some minor fixes for pre-request script sdk - INS-3379 #7225

Merged
merged 3 commits into from
Apr 9, 2024
Merged

fix: some minor fixes for pre-request script sdk - INS-3379 #7225

merged 3 commits into from
Apr 9, 2024

Conversation

ihexxa
Copy link
Contributor

@ihexxa ihexxa commented Apr 1, 2024 •
edited
Loading

Changes:

  • try to make sendRequest behavior consistent: currently the user must wrap sendRequest with Promise for resolving response, this change allows users to just add await before sendRequest.
  • try to make methods (e.g., upsert) behavior consistent and fix bugs
  • added smoke tests and unit tests

Related issue:

@ihexxa ihexxa self-assigned this Apr 1, 2024
@ihexxa ihexxa marked this pull request as draft April 1, 2024 07:11
@ihexxa ihexxa marked this pull request as ready for review April 3, 2024 08:21
@ihexxa ihexxa requested a review from a team April 3, 2024 08:23
@ihexxa ihexxa changed the title fix: some minor fixes in compatibility fix: some minor fixes for pre-request scripts sdk Apr 7, 2024
@ihexxa ihexxa changed the title fix: some minor fixes for pre-request scripts sdk fix: some minor fixes for pre-request script sdk Apr 7, 2024
@ihexxa ihexxa changed the title fix: some minor fixes for pre-request script sdk fix: some minor fixes for pre-request script sdk - INS-3379 Apr 7, 2024
@ihexxa ihexxa requested a review from a team April 8, 2024 02:31
@ihexxa ihexxa enabled auto-merge (squash) April 9, 2024 12:49
@ihexxa ihexxa merged commit aaf76f7 into develop Apr 9, 2024
7 checks passed
@ihexxa ihexxa deleted the pre-req-compatibility branch April 9, 2024 13:00
@jackkav jackkav mentioned this pull request Apr 17, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkav jackkav jackkav approved these changes

Assignees

@ihexxa ihexxa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ihexxa @jackkav