Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): some of external modules are missing - INS-3784 #7315

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

ihexxa
Copy link
Contributor

@ihexxa ihexxa commented Apr 25, 2024

Background

Some external modules can't be required, it seems that they are not part of bundle: #6242 (comment)

Changes

  • explicitly import external modules
  • add a test
  • minor code formatting

@ihexxa ihexxa self-assigned this Apr 25, 2024
@ihexxa ihexxa marked this pull request as draft April 25, 2024 08:54
@ihexxa ihexxa force-pushed the fix-pre-req-missing-ext-libs branch from 5955d25 to 2d16828 Compare April 26, 2024 02:51
@ihexxa ihexxa marked this pull request as ready for review April 26, 2024 03:10
@ihexxa ihexxa merged commit 69fb149 into develop Apr 26, 2024
7 checks passed
@ihexxa ihexxa deleted the fix-pre-req-missing-ext-libs branch April 26, 2024 11:44
@ihexxa ihexxa changed the title fix(sdk): some of external modules are missing fix(sdk): some of external modules are missing - INS-3784 Apr 30, 2024
stefancruz pushed a commit to stefancruz/insomnia that referenced this pull request May 8, 2024
* fix: some external modules are missing

* chore: update @types/tv4

* chore: use map instead of switch-case statement

* test(scripting): check using external libs in the critical test suite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants