Skip to content
This repository has been archived by the owner on Jun 5, 2024. It is now read-only.

chore: sync rate-limiting and response-ratelimiting plugins #410

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

omegabytes
Copy link
Contributor

@omegabytes omegabytes commented Sep 2, 2022

Updates the default policy from "cluster" to "local" for Kong Gateway OSS
plugins rate-limiting and response-ratelimiting.

@mikefero
Copy link
Contributor

mikefero commented Sep 2, 2022

My only suggestion here is to update the commit header and body:

  • because this is more of a sync to these plugins let's change this to a chore
    • something like chore: sync rate-limiting and response-ratelimiting plugins
  • in the body we
    • can remove the links to the documentation (not necessary in a commit and they don't actually shed any more details on what is changed)
    • update the comment reflect the chore performed
      • something like The chore synchronizes the Kong Gateway OSS plugins rate-limiting and response-ratelimting default strategy fields to local

Updates the default policy from "cluster" to "local" for Kong Gateway OSS
plugins rate-limiting and response-ratelimiting.
@omegabytes omegabytes force-pushed the feat/policy_default_to_local_rate-limiting branch from 43be11f to 571eea1 Compare September 2, 2022 16:46
@omegabytes omegabytes marked this pull request as ready for review September 2, 2022 16:47
@omegabytes omegabytes requested a review from a team as a code owner September 2, 2022 16:47
@omegabytes omegabytes changed the title feat: policy default to local for rate limiting plugins chore: sync rate-limiting and response-ratelimiting plugins Sep 2, 2022
@mikefero mikefero merged commit e1cc6f3 into main Sep 2, 2022
@mikefero mikefero deleted the feat/policy_default_to_local_rate-limiting branch September 2, 2022 17:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants