This repository has been archived by the owner on Jun 5, 2024. It is now read-only.
feat: implement consumer-group service (not exposed) #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GGabriele
force-pushed
the
feat/consumer-group-service
branch
2 times, most recently
from
79dfa8f
to
c4b2ce2
Compare
javierguerragiraldez
previously approved these changes
Dec 16, 2022
| return nil, s.err(ctx, err) | ||
| } | ||
|
|
||
| db, err := s.CommonOpts.getDB(ctx, req.Cluster) |
There was a problem hiding this comment.
very tiny nit: CommonOpts isn't needed here. s.getDB(...) is just as valid (and avoid gopls complains about this)
There was a problem hiding this comment.
you're right, thanks for pointing it out!
| cg := &v1.ConsumerGroup{ | ||
| Name: "foo", | ||
| } | ||
| res := c.GET("/v1/consumer-groups").WithJSON(cg).Expect() |
There was a problem hiding this comment.
i know this is a placeholder, but GET typically don't have a body:
Suggested change
| res := c.GET("/v1/consumer-groups").WithJSON(cg).Expect() | |
| res := c.GET("/v1/consumer-groups").Expect() |
GGabriele
force-pushed
the
feat/consumer-group-service
branch
from
c4b2ce2
to
66afa6b
Compare
aboudreault
approved these changes
Dec 16, 2022
javierguerragiraldez
approved these changes
Dec 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.