Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tail) add a tail command to follow logs #22

Merged
merged 1 commit into from
Nov 6, 2019
Merged

feat(tail) add a tail command to follow logs #22

merged 1 commit into from
Nov 6, 2019

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Nov 1, 2019

implements standard 'tail -F ' but waits for (max) 2 minutes initially for the file to appear.

The default file is './servroot/logs/error.log'.

Copy link
Contributor

@eskerda eskerda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although, since images default to logs on stdout/stderr (do they?), same could be docker-compose logs -f kong right?

@kidd
Copy link
Contributor

kidd commented Nov 4, 2019

with @eskerda's suggestion, access.log is also logged (which might be useful for non-erroring situations)

@Tieske
Copy link
Member Author

Tieske commented Nov 6, 2019

standard images do stdout/stderr but the testing framework will override this and set teh prefix to ./servroot and send the files there

Let's leave it at this now, might include access.log later, since that is more complicated as we have to wait for 2 files to appear.

implements standard 'tail -F <file>' but waits for (max) 2 minutes
initially for the file to appear.

The default file is './servroot/logs/error.log'.
@eskerda
Copy link
Contributor

eskerda commented Nov 6, 2019

Creating the files instead of waiting for them might be an option too https://github.com/Kong/kong-gojira/blob/72cd4aaebf461983ef1a858df3a23cda0bc41c00/docker/follow-log.sh#L3-L7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants