Removing upper() to allow matching of attributes #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you @krahb ! |
|
Hi,
Thanks for merging. I'm rather new to this process of contribution and I
would like to know when the changes are actually present in the pypi
package?
regards,
Bob
…On Sun, Jun 12, 2022, 16:44 Wangchong Zhou ***@***.***> wrote:
Thank you @krahb <https://github.com/krahb> !
—
Reply to this email directly, view it on GitHub
<#69 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD45EW5ADP4YV7PCP6UQHULVOXZWJANCNFSM5YNKIO3Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
thanks!
…On Mon, Jun 13, 2022, 09:26 Wangchong Zhou ***@***.***> wrote:
@krahb <https://github.com/krahb> I will release a 0.3.1 version soon #70
<#70> 😄
—
Reply to this email directly, view it on GitHub
<#69 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD45EW7PBSMSSRIRPNL2WLTVO3PDLANCNFSM5YNKIO3Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #66 .
The names of the version and priority attributes of the module are defined in lowercase.
Comparing these with the uppercase values of 'versions' and 'priority' will never match, so both version and priority attributes are never set according to the values passed in the start_dedicated_server function and remain at their defaults (being None and 0).