[feature] CLI reload #114
Merged
[feature] CLI reload #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a wrapper around `nginx reload`. Because it now makes sense, we interact with the `nginx` executable via signals, in signals.lua. We can later support `quit` for a graceful shutdown and probably remove `restart`.
thibaultcha
force-pushed
the
feature/cli-reload
branch
from
5e8d8e4 to
c20d771
Compare
ctranxuan
pushed a commit
to streamdataio/kong
that referenced
this pull request
Aug 25, 2015
[feature] CLI reload
javierguerragiraldez
pushed a commit
that referenced
this pull request
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New commands:
$ kong reload$ kong quitThis implements
kong reload#113, a wrapper aroundnginx reloadto gracefully restart Kong without downtime.kong reloadwill reload the Kong config (and thus, the contained nginx config).This change made us switch to signals to control
nginx. We can now havekong quit, for a more graceful shutdown thanstop.kong.ymlbecause it is this file which contains the nginx instance's working directory. So each command takes an optional--configargument.Usage with
/etc/kong/kong.ymlor the Luarocks one:kong startkong reloadOr with a custom configuration file:
kong start -c kong_DEVELOPMENT.ymlkong reload -c kong_DEVELOPMENT.yml