Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/ports properties #142

Merged
merged 3 commits into from
Apr 17, 2015
Merged

Feat/ports properties #142

merged 3 commits into from
Apr 17, 2015

Conversation

thibaultcha
Copy link
Member

#120

MA_kong|feat/ports-properties ⇒ kong start
[WARN] No configuration at: /etc/kong/kong.yml using default config instead.
[INFO] Using configuration: /usr/local/lib/luarocks/rocks/kong/0.2.0-1/conf/kong.yml
[INFO] Proxy port...8000
       API port.....8001
       Database.....cassandra keepalive=60000 hosts=127.0.0.1 port=9042 timeout=1000 keyspace=kong
[OK] Started

@subnetmarco
Copy link
Member

Two feedback:

  • In the doc I always call the 8001 port as the admin port. The admin port is how you manage Kong, and it happens to be through an API. I don't think the configuration property should have references to the technology used, likewise if it was a TCP API we probably wouldn't have called it the tcp_port. Another reason is that the user might thing: "What API My API or Kong API?".
  • I would call nginx_plus_status with a more generic name, like additional_configuration, to avoid referencing a specific plugin in the generic nginx configuration.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 49.85% when pulling b222057 on feat/ports-properties into 53f7d2f on master.

@thibaultcha
Copy link
Member Author

Updated. Don't forget to run make dev again to regenerate your test and development configs.

thibaultcha added a commit that referenced this pull request Apr 17, 2015
@thibaultcha thibaultcha merged commit 7d3a7b4 into master Apr 17, 2015
@thibaultcha thibaultcha deleted the feat/ports-properties branch April 17, 2015 13:52
ctranxuan pushed a commit to streamdataio/kong that referenced this pull request Aug 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants