refactor(galileo+admin) use lua-cjson's new granular encoding capabilities for empty arrays #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
changed the title
| return gsub(encoded, "\\/", "/"), #self.entries | ||
|
|
||
| --return cjson.encode(buf) | ||
| return cjson.encode(buf) |
There was a problem hiding this comment.
missing second gsub and second return value here (+ not tested apparently)
thibaultcha
force-pushed
the
refactor/cjson-empty-array
branch
2 times, most recently
from
a28f873 to
5ddf0aa
Compare
Now that openresty/lua-cjson#6 has been merged and OpenResty has been bumped to 1.9.15.1, we can use more granular empty array encoding for ALF serialization.
As per our previous commit, we use lua-cjson's new granular encoding capabilities for empty objects into array. We don't use the metatable here because it seems those are removed before the actual JSON encoding. * use cjson.empty_array for empty page results * got rid of send_HTTP()'s `raw` argument as it is not needed anymore (temporary workaround) for this use-case * appropriate tests and removed now obsolete test for send_HTTP()'s raw argument * move request size limit tests to the proper suite (/apis/ route) * add tests for number of entries returned by `serialize()`'s 2nd return value, and removal of escaped slashes in ALF encoding.
thibaultcha
force-pushed
the
refactor/cjson-empty-array
branch
from
5ddf0aa to
82ba540
Compare
thibaultcha
added
pr/ready (but hold merge)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that openresty/lua-cjson#6 has been merged
and OpenResty has been bumped to
1.9.15.1, we can use more granularempty array encoding options.
Full changelog
cjson.empty_array_mtfor ALF serializercjson.empty_arrayfor empty page results in APIsend_HTTP()'srawargument as it is not needed anymore(temporary workaround) for this use-case
send_HTTP()'s rawargument
/apis/route)