Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leaner configuration + web becomes simply "API" #156

Merged
merged 1 commit into from
Apr 24, 2015

Conversation

thibaultcha
Copy link
Member

  • delete "admin" + "static" since we don't have such a thing (and it's
    spoilers)
  • rename "kong.web" to "kong.api" since this is right now an API
  • leaner configuration: remove unused comments and properties
  • rename admin_port to admin_api_port see also rename "internal api" to "admin api" docs.konghq.com#42

I also have concerns about a lot of other properties in nginx.conf which I am not sure we want/need to include, but that might be another PR.

- delete "admin" + "static" since we don't have such a thing (and it's
  spoilers)
- rename "kong.web" to "kong.api" since this is right now an API
- leaner configuration: remove unused comments and properties
@thibaultcha
Copy link
Member Author

@thefosk thoughts?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 65.98% when pulling 9faa6b7 on default-configuration into 34300a0 on master.

@subnetmarco
Copy link
Member

+1

1 similar comment
@nijikokun
Copy link
Contributor

👍

thibaultcha added a commit that referenced this pull request Apr 24, 2015
leaner configuration + web becomes simply "API"
@thibaultcha thibaultcha merged commit e56ccd5 into master Apr 24, 2015
@thibaultcha thibaultcha deleted the default-configuration branch April 24, 2015 11:41
ctranxuan pushed a commit to streamdataio/kong that referenced this pull request Aug 25, 2015
leaner configuration + web becomes simply "API"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants