[feat/dao] implement cascade deletion for Cassandra #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements a "delete hook" system to trigger cascade deletion of foreign rows in Cassandra. To do so, all foreign columns (representing foreign keys) must now be queryable (which means be indexed by Cassandra). A "delete hook" is added to a parent DAO if any other DAO has foreign rows to that DAO. Ex: APIs are parents to plugins_credentials, hence the `apis` DAO will have a delete hook on the deletion of a row, to also delete any related `plugins_configurations`. - Move cascade delete tests to another file, with all use cases of current cascade deletion. - Add a migration for oauth2 plugin to index the `consumer_id` field. - Remove obsolete overridden delete methods of apis and consumers DAOs. This should be a solution to #438 and is an improved implementation of #107
thibaultcha
added
NEEDS REVIEW
pr/ready (but hold merge)
thibaultcha
added a commit
that referenced
this pull request
Aug 26, 2015
[feat/dao] implement cascade deletion for Cassandra
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a "delete hook" system to trigger cascade deletion of foreign rows in Cassandra. To do so, all foreign columns (representing foreign keys) must now be queryable (which means be indexed by Cassandra).
A "delete hook" is added to a parent DAO if any other DAO has foreign rows to that DAO. Ex: APIs are parents to plugins_credentials, hence the
apisDAO will have a delete hook on the deletion of a row, to also delete any relatedplugins_configurations.consumer_idfield.This should be a solution to #438 and is an improved implementation of #107.
PS: I don't really like taking care of this at the application level but what choice do we have.