fix(tracing): span start/end time precision #11484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samugi
force-pushed
the
fix/tracing-span-precision
branch
from
39ef131
to
03b336a
Compare
samugi
force-pushed
the
fix/tracing-span-precision
branch
from
03b336a
to
cc11862
Compare
|
Rerunning all the tests as it seems the artificials are broken. |
samugi
force-pushed
the
fix/tracing-span-precision
branch
from
cc11862
to
a331ebc
Compare
StarlightIbuki
approved these changes
Sep 11, 2023
samugi
force-pushed
the
fix/tracing-span-precision
branch
from
9ed7459
to
564b9c2
Compare
Ensure the span lifetime is consistent with the hierarchy by using the same time source for the root span's end time as the balancer span. Before this fix, an approximation (causing a precision error) could result in the root span to end before its children.
Co-authored-by: Xumin <100666470+StarlightIbuki@users.noreply.github.com>
samugi
force-pushed
the
fix/tracing-span-precision
branch
from
564b9c2
to
7f92e13
Compare
team-gateway-bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
* fix(tracing): span start/end time precision Ensure the span lifetime is consistent with the hierarchy by using the same time source for the root span's end time as the balancer span. Before this fix, an approximation (causing a precision error) could result in the root span to end before its children. * docs(changelog): add issue Co-authored-by: Xumin <100666470+StarlightIbuki@users.noreply.github.com> --------- Co-authored-by: Xumin <100666470+StarlightIbuki@users.noreply.github.com> (cherry picked from commit 37a17eb)
samugi
added a commit
that referenced
this pull request
Sep 13, 2023
* fix(tracing): span start/end time precision Ensure the span lifetime is consistent with the hierarchy by using the same time source for the root span's end time as the balancer span. Before this fix, an approximation (causing a precision error) could result in the root span to end before its children. * docs(changelog): add issue Co-authored-by: Xumin <100666470+StarlightIbuki@users.noreply.github.com> --------- Co-authored-by: Xumin <100666470+StarlightIbuki@users.noreply.github.com> (cherry picked from commit 37a17eb) Co-authored-by: Samuele <samuele@konghq.com>
|
@samugi is there a reason for not backporting this further (e.g 3.3) |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.3.x release/3.3.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.3.x
# Create a new branch
git switch --create backport-11484-to-release/3.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 37a17eb491a8b85b2dd01f994bd48a3757ad216a
# Push it to GitHub
git push --set-upstream origin backport-11484-to-release/3.3.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.3.xThen, create a pull request where the |
3 tasks
kikito
pushed a commit
that referenced
this pull request
Sep 26, 2023
* fix(tracing): span start/end time precision Ensure the span lifetime is consistent with the hierarchy by using the same time source for the root span's end time as the balancer span. Before this fix, an approximation (causing a precision error) could result in the root span to end before its children. * docs(changelog): add issue Co-authored-by: Xumin <100666470+StarlightIbuki@users.noreply.github.com> --------- Co-authored-by: Xumin <100666470+StarlightIbuki@users.noreply.github.com>
samugi
added a commit
that referenced
this pull request
Sep 27, 2023
* fix(tracing): span start/end time precision Ensure the span lifetime is consistent with the hierarchy by using the same time source for the root span's end time as the balancer span. Before this fix, an approximation (causing a precision error) could result in the root span to end before its children. * docs(changelog): add issue Co-authored-by: Xumin <100666470+StarlightIbuki@users.noreply.github.com> --------- Co-authored-by: Xumin <100666470+StarlightIbuki@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure the span lifetime is consistent with the spans hierarchy by using the same time precision for the root span's "end time" as the balancer span.
Before this fix, using millisecond precision instead of nano could result in the root span to end before its children.
Checklist
CHANGELOG/unreleased/kongor addingskip-changeloglabel on PR if unnecessary. README.md (Please ping @vm-001 if you need help)There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HEREFull changelog
Issue reference
KAG-2336
Fix #11294 (secondary issue reported in the comments)