Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(router): move some declarations into local scope #12014

Merged
merged 3 commits into from
Nov 16, 2023
Merged

refactor(router): move some declarations into local scope #12014

merged 3 commits into from
Nov 16, 2023

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Nov 14, 2023 •
edited
Loading

Summary

It is a small improvement of #12008，moving some declarations into do end block.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

bungle
bungle requested changes Nov 14, 2023
View reviewed changes
kong/router/utils.lua Outdated Show resolved Hide resolved
@windmgc windmgc merged commit 3741773 into master Nov 16, 2023
24 checks passed
@windmgc windmgc deleted the refactor/clean_phonehome_statistics branch November 16, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bungle bungle bungle approved these changes

@Water-Melon Water-Melon Water-Melon approved these changes

Assignees

@chronolaw chronolaw

Labels
size/XS skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chronolaw @bungle @Water-Melon @windmgc