Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugin/response-transformer): added support for json_body rename #12888

Closed
wants to merge 0 commits into from
Closed

feat(plugin/response-transformer): added support for json_body rename #12888

wants to merge 0 commits into from

Conversation

zhongweikang
Copy link
Contributor

@zhongweikang zhongweikang commented Apr 19, 2024 •
edited by kikito
Loading

Summary

detail here: #12824.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

KAG-4664

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added schema-change-noteworthy cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Apr 19, 2024
@team-eng-enablement team-eng-enablement added the author/community PRs from the open-source community (not Kong Inc) label Apr 19, 2024
@zhongweikang
Copy link
Contributor Author

Hey @bungle. Can you help me approval this workflow?
I added new fields to removed_fields.lua and added a test for this.
Thank you so much.

@zhongweikang zhongweikang force-pushed the master branch 4 times, most recently from 1c10aa1 to e4ae1b1 Compare May 4, 2024 08:33
@chronolaw chronolaw changed the title feat(response-transformer): added support for json_body rename feat(plugin/response-transformer): added support for json_body rename May 7, 2024
@zhongweikang
Copy link
Contributor Author

Hey @chronolaw, I read the error logs of the test runner, but I didn't find anything related to my changes. could you help me with that?

@chronolaw chronolaw requested review from jschmid1 and samugi May 7, 2024 08:46
@chronolaw
Copy link
Contributor

Hey @chronolaw, I read the error logs of the test runner, but I didn't find anything related to my changes. could you help me with that?

Some test cases are flaky, rerun the tests can make them green.

@zhongweikang zhongweikang force-pushed the master branch 2 times, most recently from cee4088 to 017b787 Compare May 28, 2024 16:02
@zhongweikang
Copy link
Contributor Author

@samugi @jschmid1 could you help to take a look at this PR?

@samugi samugi closed this May 31, 2024
@samugi
Copy link
Member

samugi commented May 31, 2024

closing was unintentional! I intended to resolve conflicts but the force-push resulted in the PR to auto-close

@zhongweikang
Copy link
Contributor Author

zhongweikang commented May 31, 2024 •
edited
Loading

closing was unintentional! I intended to resolve conflicts but the force-push resulted in the PR to auto-close

@samugi So I should start a new PR？

@samugi samugi mentioned this pull request May 31, 2024
Merged
3 tasks
@samugi
Copy link
Member

samugi commented May 31, 2024

@zhongweikang reopened here: #13131
so sorry about my mistake :( and thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschmid1 jschmid1 jschmid1 approved these changes

@samugi samugi Awaiting requested review from samugi

Assignees
No one assigned
Labels
author/community PRs from the open-source community (not Kong Inc) cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/clustering plugins/response-transformer schema-change-noteworthy size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zhongweikang @CLAassistant @chronolaw @samugi @jschmid1 @guanlan @team-eng-enablement