chore(deps): add (and bump) cross deps versions to .requirements #13117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
build/bazel
cherry-pick kong-ee
|
It is not obvious to me where these are even used, I mean are those cross_deps even built? |
|
@fffonion do you know do we need these (e.g. libxcrypt?), or can these |
### Summary The cross deps versions placed directly to repective dep `repositories.bzl`. This commit moves the versions and SHA256 digests to `.requirerements`. It also bumps version of `libzlib` from `1.2.13` to `1.3.1`, and `libxcrypt` from `4.4.27` to `4.4.36`. Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
kikito
force-pushed
the
chore/bump-cross-deps
branch
from
cdab4e3
to
a0dfed9
Compare
kikito
approved these changes
Jul 5, 2024
samugi
approved these changes
Jul 5, 2024
|
Successfully created cherry-pick PR for |
|
we shouldn't bump the version of those dependencies, they should remain/align with the oldest distros we ship. they are not bundled in the binary package, but only to provide headers and .so to make compiler and linker happy in cross compilation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit moves the versions and SHA256 digests to
.requirements.It also bumps version of
libzlibfrom1.2.13to1.3.1, andlibxcryptfrom4.4.27to4.4.36.KAG-4615
KAG-4616
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.md