-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugins): enable ai plugins to read request body from buffered file #13158
Conversation
a231e49
to
ff8aef7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need update removed_fields
correspondingly?
@liverpool8056 yes, i didn't notice removed_fields is also present on CE, will fix. |
d1fa11f
to
5e5b44c
Compare
1df6c4c
to
fafc988
Compare
0c82e34
to
92eefed
Compare
e197020
to
2f7d8d8
Compare
I did a force push to port the backward compat tests from EE PR. |
max_request_body_size field
2f7d8d8
to
eba070f
Compare
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13158-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13158-to-master-to-upstream
git checkout -b cherry-pick-13158-to-master-to-upstream
ancref=$(git merge-base 4664b907c86cf95d8ad98c7f51dce768c52070c3 eba070f49480b40d6c3449a80aeea8e3c88cc64b)
git cherry-pick -x $ancref..eba070f49480b40d6c3449a80aeea8e3c88cc64b |
@fffonion could you take care of the manual cherry-pick, please? |
|
||
else | ||
return "" | ||
local file, err = io.open(body_file, "r") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO it's safer to read the file content as binary. local file, err = io.open(body_file, "rb")
. Just to be safe. https://www.lua.org/pil/21.2.2.html
Summary
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
AG-39
#13211