feat(admin_api): support map brackets syntax #13313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/admin-api
cherry-pick kong-ee
samugi
force-pushed
the
feat/escape-chars-config-keys
branch
from
579d179
to
86ef821
Compare
samugi
changed the title
samugi
force-pushed
the
feat/escape-chars-config-keys
branch
from
86ef821
to
ab46327
Compare
samugi
force-pushed
the
feat/escape-chars-config-keys
branch
2 times, most recently
from
5d3f8ca
to
80a992c
Compare
samugi
commented
Jul 1, 2024
samugi
force-pushed
the
feat/escape-chars-config-keys
branch
from
4303359
to
c3df196
Compare
nowNick
reviewed
Jul 4, 2024
samugi
force-pushed
the
feat/escape-chars-config-keys
branch
5 times, most recently
from
25351aa
to
599f3e1
Compare
|
@nowNick Thanks so much for the great review! My initial objective with this PR was to keep the scope as small as possible, that is why you noticed similarities with existing code, but I have to say that I also agree all your suggestions are improvements. At the same time I don't know how we feel about adding a large refactor on top of this PR, so in the end I did pretty much everything you said (with some additions as I'm about to answer on individual comments) but kept it as a separate commit so we can decide to split it out if needed. I think this is good because the splitting of things resulted in a lot of new unit tests and some more order IMO. |
kikito
reviewed
Jul 5, 2024
This commit adds support for configuring maps using brackets syntax to enclose the key: ``` http -f post :8001/plugins/ \ name=opentelemetry \ config.endpoint=http://test.test \ config.resource_attributes[service.name]=kong-dev ``` feat(admin_api): support url encoded brackets
samugi
force-pushed
the
feat/escape-chars-config-keys
branch
from
599f3e1
to
f6a13d1
Compare
samugi
removed
the
cherry-pick kong-ee
bungle
approved these changes
Jul 5, 2024
* split the arguments module to separate the decoding logic into arguments_decoder.lua * simplified matching logic: extended some regex patterns to cover some of the logic that was done in Lua * split large functions into more smaller ones in arguments_decoder.lua * added unit tests for new functions
samugi
force-pushed
the
feat/escape-chars-config-keys
branch
from
f6a13d1
to
620b016
Compare
github-actions
bot
added
the
cherry-pick kong-ee
nowNick
approved these changes
Jul 10, 2024
samugi
removed
the
cherry-pick kong-ee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note for reviewers: use hide whitespace if reviewing from gh
Summary
This commit adds support for configuring maps using brackets syntax to
enclose the key:
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
KAG-4827