-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): graceful scan-images job execution during grype cdn failures #13507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
chore
Not part of the core functionality of kong, but still needed
label
Aug 16, 2024
saisatishkarra
force-pushed
the
feat/scan-images-config
branch
from
August 16, 2024 11:00
f681eec
to
d4a5680
Compare
saisatishkarra
force-pushed
the
feat/scan-images-config
branch
from
August 16, 2024 11:45
3b0fc13
to
0c110a9
Compare
Water-Melon
force-pushed
the
feat/scan-images-config
branch
from
August 16, 2024 13:24
0c110a9
to
bb7b5c9
Compare
saisatishkarra
force-pushed
the
feat/scan-images-config
branch
from
August 16, 2024 14:48
bb7b5c9
to
1bfd375
Compare
Water-Melon
approved these changes
Aug 16, 2024
saisatishkarra
force-pushed
the
feat/scan-images-config
branch
from
August 16, 2024 21:22
1bfd375
to
92ee750
Compare
saisatishkarra
force-pushed
the
feat/scan-images-config
branch
from
August 16, 2024 21:25
92ee750
to
a6c3c3e
Compare
saisatishkarra
requested review from
Water-Melon,
AndyZhang0707 and
curiositycasualty
August 16, 2024 21:38
saisatishkarra
changed the title
chore(ci): Ability to skip scan-images job during grype cdn failures
chore(ci): graceful scan-images job execution during grype cdn failures
Aug 16, 2024
Water-Melon
approved these changes
Aug 17, 2024
windmgc
approved these changes
Aug 19, 2024
saisatishkarra
force-pushed
the
feat/scan-images-config
branch
from
August 19, 2024 13:35
a6c3c3e
to
ef5363f
Compare
Add grype GH cache to reuse across jobs Add GH timeout for scan-images job
Signed-off-by: saisatishkarra <saisatish.karra@konghq.com>
saisatishkarra
force-pushed
the
feat/scan-images-config
branch
from
August 19, 2024 13:45
ef5363f
to
7423df9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The SCA tool (grype) invoked as part scan-images job downloads the vulnerability DB on each run. This is leading to issues dues to Grype CDN failures sporadically:
Long running jobs failing due to timeout (job resource wastage) when the job is stuck / hung up
Interim solutions to address from multiple fronts:
Summary
vars.DISABLE_SCA_SCAN
in the repository variable of emergency when enforcement / fail_build istrue
. Only Github Admin / Repo Admin access can perform this.scan-actions
version to use GH cache as part of[2.4.0](https://github.com/Kong/public-shared-actions/releases/tag/v2.4.0)
Long term solutions:
Effect:
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]