-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(helpers): separate db functions #13618
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
label
Sep 4, 2024
chronolaw
force-pushed
the
tests/clean_helpers_db
branch
from
September 4, 2024 10:44
2b22705
to
3d3cb0e
Compare
chronolaw
force-pushed
the
tests/clean_helpers_db
branch
3 times, most recently
from
September 10, 2024 04:37
132d7b1
to
0ad9a86
Compare
This reverts commit d852f65.
chronolaw
force-pushed
the
tests/clean_helpers_db
branch
from
September 10, 2024 09:28
255bccd
to
d783491
Compare
ProBrian
approved these changes
Sep 11, 2024
Water-Melon
approved these changes
Sep 11, 2024
chobits
approved these changes
Sep 11, 2024
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13618-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13618-to-master-to-upstream
git checkout -b cherry-pick-13618-to-master-to-upstream
ancref=$(git merge-base 1989ea7091b3cb191a6eeea6928f2493d798cefb d7834912bd7b1fee007163663da66b298019fcdb)
git cherry-pick -x $ancref..d7834912bd7b1fee007163663da66b298019fcdb |
github-actions
bot
added
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Sep 11, 2024
AndyZhang0707
removed
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
KAG-5322
dcdp
andPLUGINS_LIST
now turn to functions, since they are initialized inget_db_utils()
.extra_fields
for the functionvalidate_plugin_config_schema()
to be compatible with EEconf
out ofshell
moduleChecklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]