Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(helpers): separate db functions #13618

Merged
merged 22 commits into from
Sep 11, 2024
Merged

tests(helpers): separate db functions #13618

merged 22 commits into from
Sep 11, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Sep 4, 2024

Summary

KAG-5322

  • The original dcdp and PLUGINS_LIST now turn to functions, since they are initialized in get_db_utils().
  • Add a param extra_fields for the function validate_plugin_config_schema() to be compatible with EE
  • move conf out of shell module

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Sep 4, 2024
@chronolaw chronolaw marked this pull request as ready for review September 4, 2024 23:44
@chronolaw chronolaw force-pushed the tests/clean_helpers_db branch 3 times, most recently from 132d7b1 to 0ad9a86 Compare September 10, 2024 04:37
@ADD-SP ADD-SP merged commit 227396f into master Sep 11, 2024
25 checks passed
@ADD-SP ADD-SP deleted the tests/clean_helpers_db branch September 11, 2024 07:51
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13618-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13618-to-master-to-upstream
git checkout -b cherry-pick-13618-to-master-to-upstream
ancref=$(git merge-base 1989ea7091b3cb191a6eeea6928f2493d798cefb d7834912bd7b1fee007163663da66b298019fcdb)
git cherry-pick -x $ancref..d7834912bd7b1fee007163663da66b298019fcdb

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Sep 11, 2024
@AndyZhang0707 AndyZhang0707 removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/XL skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants