Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): migrate bazelbuild/setup-bazelisk to bazel-contrib/setup-bazel #13622

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

Water-Melon
Copy link
Contributor

Summary

According to the bazelbuild/setup-bazelisk README, the action is superseded by the bazel-contrib/setup-bazel. Please check if we need to migrate to the new action. One of the possible motivation of this migration is that node.js 16 is deprecated soon from github runners.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-5221

@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Sep 5, 2024
@Water-Melon Water-Melon force-pushed the kag5221_bazelbuild_to_bazelcontrib branch 2 times, most recently from 54dd59f to 35ef09c Compare September 5, 2024 07:41
@Water-Melon Water-Melon force-pushed the kag5221_bazelbuild_to_bazelcontrib branch from 606fe3a to e8adf5d Compare September 5, 2024 08:13
@Water-Melon Water-Melon force-pushed the kag5221_bazelbuild_to_bazelcontrib branch from 0d25199 to 90cdd9a Compare September 6, 2024 07:25
@Water-Melon
Copy link
Contributor Author

@Water-Melon Water-Melon force-pushed the kag5221_bazelbuild_to_bazelcontrib branch from 73e624a to 8ec3217 Compare September 11, 2024 07:09
@pull-request-size pull-request-size bot added size/S and removed size/L labels Sep 11, 2024
@Water-Melon Water-Melon marked this pull request as ready for review September 11, 2024 07:18
Copy link
Member

@windmgc windmgc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as long as full matrix build passed

@windmgc windmgc merged commit c498f41 into master Sep 11, 2024
18 checks passed
@windmgc windmgc deleted the kag5221_bazelbuild_to_bazelcontrib branch September 11, 2024 07:54
@Water-Melon Water-Melon added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Sep 11, 2024
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13622-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13622-to-master-to-upstream
git checkout -b cherry-pick-13622-to-master-to-upstream
ancref=$(git merge-base 4f63f13479143c7738c0b50b5c10b24b1995ebb4 8ec321716e885281388fd7c3191c1b2bde0a7de9)
git cherry-pick -x $ancref..8ec321716e885281388fd7c3191c1b2bde0a7de9

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Sep 11, 2024
fffonion added a commit that referenced this pull request Sep 11, 2024
@fffonion
Copy link
Contributor

The build cache is causing problems, we don't want that paritucally on a release action to avoid popluting artifacts.

@AndyZhang0707 AndyZhang0707 removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Sep 24, 2024
curiositycasualty pushed a commit that referenced this pull request Oct 15, 2024
…azel (#13622)

According to the bazelbuild/setup-bazelisk README, the action is superseded by the bazel-contrib/setup-bazel. Please check if we need to migrate to the new action. One of the possible motivation of this migration is that node.js 16 is deprecated soon from github runners.

KAG-5221

(cherry picked from commit c498f41)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee chore Not part of the core functionality of kong, but still needed size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants