feat(config) allow octothorpes in config directives

Previously we treated all tokens after a comment character ("#")
as comments. This commit updates this behavior to recognize escaped
octothorpes as literal characters, and adjusted the directive
appropriately.

kong/conf_loader.lua

@@ -138,7 +138,12 @@ local function check_and_infer(conf)
     local typ = v_schema.typ
 
     if type(value) == "string" then
-      value = string.gsub(value, "#.-$", "") -- remove trailing comment if any
+
+      -- remove trailing comment, if any
+      -- and remove escape chars from octothorpes
+      value = string.gsub(value, "[^\\]#.-$", "")
+      value = string.gsub(value, "\\#", "#")
+
       value = pl_stringx.strip(value)
     end
 

spec/01-unit/02-conf_loader_spec.lua

@@ -116,6 +116,10 @@ describe("Configuration loader", function()
     assert.True(conf.plugins.foobar)
     assert.True(conf.plugins["hello-world"])
   end)
+  it("correctly parses values containing an octothorpe", function()
+    local conf = assert(conf_loader("spec/fixtures/to-strip.conf"))
+    assert.equal("test#123", conf.pg_password)
+  end)
 
   describe("nginx_user", function()
     it("is nil by default", function()

spec/fixtures/to-strip.conf

@@ -4,6 +4,8 @@ log_level =        debug       # strip this
 pg_ssl = off                     # Toggles client-server TLS connections
                                  # between Kong and PostgreSQL.
 
+pg_password = test\#123  # do not strip an escaped octothorpe
+
 dns_resolver = 8.8.8.8
 
 cassandra_data_centers = dc1:2,   dc2:3  , dc3:4