feat(admin) change behaviour of GET target requests #3049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The endpoints to list active and all Targets associated with an Upstream have been changed as follows: * `GET /upstreams/:upstream_name_or_id/targets/` now lists only the active Targets instead of listing all The targets. Previously, active targets were available at the endpoint `/upstreams/:upstream_name_or_id/targets/active`, which is now removed. * `GET /upstreams/:upstream_name_or_id/targets/all` endpiont is introduced, which returns a list of all the Targets (old and current).
thibaultcha
approved these changes
Dec 15, 2017
There was a problem hiding this comment.
Awesome, this looks great, thanks @hbagdi, we'll include it in 0.12!
thibaultcha
pushed a commit
that referenced
this pull request
Jan 16, 2018
Breaking change: The endpoints to list active and all Targets associated with an Upstream have been changed as follows: * `/upstreams/:upstream_name_or_id/targets/active` is removed. * `/upstreams/:upstream_name_or_id/targets/` now only lists the active Targets instead of listing all of them. * `/upstreams/:upstream_name_or_id/targets/all` is introduced, which returns a list of all the Targets (old and current), as per the previous behavior of the `/targets/` endpoint. From #3049 Closes #2791
thibaultcha
pushed a commit
that referenced
this pull request
Jan 19, 2018
Breaking change: The endpoints to list active and all Targets associated with an Upstream have been changed as follows: * `/upstreams/:upstream_name_or_id/targets/active` is removed. * `/upstreams/:upstream_name_or_id/targets/` now only lists the active Targets instead of listing all of them. * `/upstreams/:upstream_name_or_id/targets/all` is introduced, which returns a list of all the Targets (old and current), as per the previous behavior of the `/targets/` endpoint. From #3049 Closes #2791
hanhui870
pushed a commit
to hanhui870/kong-dashboard
that referenced
this pull request
Jan 27, 2018
To reduce confusion, the /upstreams/:upstream_name_or_id/targets/ has been updated to not show the full list of Targets anymore, but only the ones that are currently active in the load balancer. To retrieve the full history of Targets, you can now query /upstreams/:upstream_name_or_id/targets/all. The /upstreams/:upstream_name_or_id/targets/active endpoint has been removed. Thanks @hbagdi for tackling this backlog item! Kong/kong#3049
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The endpoints to list active and all Targets associated
with an Upstream have been changed as follows:
GET /upstreams/:upstream_name_or_id/targets/nowlists only the active Targets instead of listing all The targets.
Previously, active targets were available at the endpoint
/upstreams/:upstream_name_or_id/targets/active, which is nowremoved.
GET /upstreams/:upstream_name_or_id/targets/allendpiont isintroduced, which returns a list of all the Targets (old and current).
Issues resolved
Fix #2791
TODO