Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins) raise ip-restriction priority to 3000 #3516

Merged
merged 2 commits into from
Jun 6, 2018

Conversation

nijikokun
Copy link
Contributor

Summary

Raises the priority of the ip-restriction plugin to 3000 so that it runs before other plugins, after Zipkin, just as bot-detection does to prevent code execution that is not required.

See: https://getkong.org/docs/0.13.x/plugin-development/custom-logic/#plugins-execution-order

@thibaultcha thibaultcha merged commit dcb2536 into next Jun 6, 2018
@thibaultcha thibaultcha deleted the fix/raise-ip-restriction-priority branch June 6, 2018 04:26
@Tieske
Copy link
Member

Tieske commented Jun 6, 2018

Since this plugin can be attached to a consumer, it MUST run after the auth plugions.

@thibaultcha
Copy link
Member

What would be the use case for specifying this plugin to a Consumer?

@Tieske
Copy link
Member

Tieske commented Jun 7, 2018

I don't know really, but it will break expectations if it doesn't do that. So the alternative is to add the no_consumer flag to the IP-restriction plugin.

Either way something needs to be updated.

@thibaultcha
Copy link
Member

Update for visibility purposes: this was reverted in 380535a, before the 0.14.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants