Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kmultiselect): duplicate placeholder [KHCP-12560] #2274

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

portikM
Copy link
Member

@portikM portikM commented Jul 10, 2024

Summary

Addresses: https://konghq.atlassian.net/browse/KHCP-12560

When a placeholder is provided, display it in dropdown input. In selections container, only display 0 items selected when no selections have been made

Screenshot 2024-07-10 at 10 13 18 AM

@portikM portikM self-assigned this Jul 10, 2024
Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 16849b4
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/668e969006669f00080062e0
😎 Deploy Preview https://deploy-preview-2274--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@portikM portikM marked this pull request as ready for review July 10, 2024 14:14
@portikM portikM requested a review from a team as a code owner July 10, 2024 14:14
@portikM portikM merged commit f4542de into main Jul 10, 2024
5 checks passed
@portikM portikM deleted the fix/khcp-12560-kmultiselect-placeholder branch July 10, 2024 14:26
kongponents-bot pushed a commit that referenced this pull request Jul 10, 2024
## [9.0.9](v9.0.8...v9.0.9) (2024-07-10)

### Bug Fixes

* **kmultiselect:** duplicate placeholder [KHCP-12560] ([#2274](#2274)) ([f4542de](f4542de))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.0.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants