fix: gernerate a catch-all route for rules with no matches and no hostnames in HTTPRoute and GRPCRoute #4528
Codecov / codecov/project
succeeded
Aug 17, 2023 in 1s
67.8% (-0.1%) compared to 13c8d70
View this Pull Request on Codecov
67.8% (-0.1%) compared to 13c8d70
Details
Codecov Report
Patch coverage: 57.1% and project coverage change: -0.1%
Comparison is base (
13c8d70) 67.9% compared to head (3756e7d) 67.8%.
Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #4528 +/- ##
=======================================
- Coverage 67.9% 67.8% -0.1%
=======================================
Files 161 161
Lines 18904 18913 +9
=======================================
- Hits 12842 12836 -6
- Misses 5307 5318 +11
- Partials 755 759 +4 | Files Changed | Coverage Δ | |
|---|---|---|
| internal/dataplane/parser/translate_grpcroute.go | 77.7% <ø> (-0.8%) |
⬇️ |
| internal/dataplane/parser/translators/atc_utils.go | 100.0% <ø> (ø) |
|
| ...rnal/dataplane/parser/translators/httproute_atc.go | 92.7% <43.7%> (-2.2%) |
⬇️ |
| internal/dataplane/parser/translate_httproute.go | 77.5% <100.0%> (-1.1%) |
⬇️ |
| ...rnal/dataplane/parser/translators/grpcroute_atc.go | 93.6% <100.0%> (+<0.1%) |
⬆️ |
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
Loading