Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include Licenses and ConsumerGroups in sanitized copies of config #4710

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

czeslavo
Copy link
Contributor

What this PR does / why we need it:

We missed adding Licenses and ConsumerGroups to the sanitized copies. This PR adds them, as well as improves tests to catch such cases in the future automatically.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@czeslavo czeslavo self-assigned this Sep 22, 2023
@czeslavo czeslavo added the fix label Sep 22, 2023
@czeslavo czeslavo added this to the KIC v2.12.0 milestone Sep 22, 2023
@czeslavo czeslavo marked this pull request as ready for review September 22, 2023 13:58
@czeslavo czeslavo requested a review from a team as a code owner September 22, 2023 13:58
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 93.7% and project coverage change: +0.1% 🎉

Comparison is base (3bb59ca) 67.8% compared to head (3eaaa7c) 67.9%.
Report is 2 commits behind head on main.

❗ Current head 3eaaa7c differs from pull request most recent head 63a1c06. Consider uploading reports for the commit 63a1c06 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4710     +/-   ##
=======================================
+ Coverage   67.8%   67.9%   +0.1%     
=======================================
  Files        164     165      +1     
  Lines      19289   19303     +14     
=======================================
+ Hits       13083   13115     +32     
+ Misses      5432    5418     -14     
+ Partials     774     770      -4     
Files Changed Coverage Δ
internal/dataplane/deckgen/generate.go 62.6% <0.0%> (ø)
internal/dataplane/kongstate/kongstate.go 74.0% <100.0%> (+0.3%) ⬆️
internal/dataplane/kongstate/license.go 100.0% <100.0%> (ø)
internal/dataplane/parser/parser.go 82.8% <100.0%> (-0.2%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czeslavo czeslavo enabled auto-merge (squash) September 22, 2023 14:34
Co-authored-by: Jakub Warczarek <jakub.warczarek@konghq.com>
@czeslavo czeslavo merged commit 1e541bb into main Sep 22, 2023
32 checks passed
@czeslavo czeslavo deleted the fix/consumer-groups-sanitized branch September 22, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants