Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate KongIngress entirely #5015

Closed
wants to merge 1 commit into from

Conversation

czeslavo
Copy link
Contributor

What this PR does / why we need it:

Makes .Service and .Route fields not allowed with the use of the CRD validations. Makes .Upstream deprecated by returning a warning from the admission webhook and not using the field at all.

Which issue this PR fixes:

Closes #4720.

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@czeslavo czeslavo added the area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. label Oct 30, 2023
@czeslavo czeslavo added this to the KIC v3.0.0 milestone Oct 30, 2023
@czeslavo czeslavo self-assigned this Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8c727d9) 75.3% compared to head (80f2198) 75.5%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5015     +/-   ##
=======================================
+ Coverage   75.3%   75.5%   +0.2%     
=======================================
  Files        167     167             
  Lines      18719   18526    -193     
=======================================
- Hits       14097   13993    -104     
+ Misses      3794    3721     -73     
+ Partials     828     812     -16     
Files Coverage Δ
internal/adminapi/backoff_strategy_konnect.go 100.0% <ø> (ø)
internal/adminapi/client.go 55.8% <ø> (ø)
internal/adminapi/endpoints.go 84.2% <ø> (ø)
internal/adminapi/kong.go 61.9% <ø> (ø)
internal/adminapi/konnect.go 0.0% <ø> (ø)
internal/admission/adminapi_provider.go 89.4% <ø> (ø)
internal/admission/handler.go 58.6% <100.0%> (-1.0%) ⬇️
internal/admission/utils.go 81.0% <ø> (ø)
...ion/validation/consumers/credentials/validation.go 96.2% <ø> (ø)
internal/admission/validation/gateway/httproute.go 90.0% <ø> (ø)
... and 110 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czeslavo czeslavo force-pushed the chore/deprecate-kong-ingress branch 3 times, most recently from 725e3b7 to 8fec9e7 Compare October 30, 2023 16:42
@czeslavo
Copy link
Contributor Author

Closing in favor of #5022.

@czeslavo czeslavo closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate KongIngress CRD entirely
1 participant