Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove logs to print config and correct integration test names #5320

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Dec 12, 2023

What this PR does / why we need it:

  • Remove the logging of generated plugin config to avoid sensitive information in debug logs
  • Update names of integration tests on validating secrets

Which issue this PR fixes:

following fix of #5203.

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

- [ ] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR I think No need to update CHANGELOG

@randmonkey randmonkey requested a review from a team as a code owner December 12, 2023 08:33
@randmonkey randmonkey self-assigned this Dec 12, 2023
@randmonkey randmonkey added this to the KIC v3.1.x milestone Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (00b12e1) 75.9% compared to head (b2fe07f) 75.8%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5320     +/-   ##
=======================================
- Coverage   75.9%   75.8%   -0.1%     
=======================================
  Files        170     170             
  Lines      19549   19544      -5     
=======================================
- Hits       14845   14828     -17     
- Misses      3865    3875     +10     
- Partials     839     841      +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@randmonkey
Copy link
Contributor Author

Seems that the added test is flaky: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/7178831047/job/19547840672?pr=5320. @czeslavo Do you think it is a good way to fix in this PR, or create another issue and fix it later?

@czeslavo
Copy link
Contributor

Seems that the added test is flaky: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/7178831047/job/19547840672?pr=5320. @czeslavo Do you think it is a good way to fix in this PR, or create another issue and fix it later?

I cannot see this PR adding any new test so I think it's fine to fix it separately. 🤔

@randmonkey randmonkey merged commit 58d6be6 into main Dec 12, 2023
65 checks passed
@randmonkey randmonkey deleted the chore/fix_names_webhook_test_validate_secrets branch December 12, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants