feat: don't validate HTTPRoute for allowedRoutes and listeners in webhook

[czeslavo]

What this PR does / why we need it:

Removes HTTPRoute validations from the admission webhook:

• HTTPRoute matches Gateway Listener's AllowedRoutes kind,
• Gateway has a Listener matching an HTTPRoute's protocol,
• Gateway has a Listener matching an HTTPRoute's section name (NotAllowedByListeners).

All of these validations are already handled in the controller itself:

• kubernetes-ingress-controller/internal/controllers/gateway/route_utils.go

  Line 216 in 2e22a10

  if ok, err := routeMatchesListenerAllowedRoutes(ctx, mgrc, route, listener, gateway.Namespace, parentRef.Namespace); err != nil {

• kubernetes-ingress-controller/internal/controllers/gateway/route_utils.go

  Line 270 in 2e22a10

  if !routeTypeMatchesListenerType(route, listener) {

• kubernetes-ingress-controller/internal/controllers/gateway/route_utils.go

  Line 245 in 2e22a10

  if *parentRef.SectionName != "" && *parentRef.SectionName != listener.Name {

All of these are now tested as well (on the unit test level):

• kubernetes-ingress-controller/internal/controllers/gateway/route_utils_test.go

  Line 419 in 2e22a10

  name: "basic HTTPRoute does not get accepted if it is not in the supported kinds",

  (NotAllowedByListeners)

• kubernetes-ingress-controller/internal/controllers/gateway/route_utils_test.go

  Line 536 in cd74f82

  name: "HTTPRoute does not get accepted if Listener doesn't match route's protocol",

  (NoMatchingParent)

• kubernetes-ingress-controller/internal/controllers/gateway/route_utils_test.go

  Line 555 in cd74f82

  name: "HTTPRoute does not get accepted if Listener doesn't match route's section name",

  (NotAllowedByListeners)

Which issue this PR fixes:

Fixes #5197.

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

• the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

[codecov]

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (3993e0a) 69.8% compared to head (c31d53a) 69.7%.
Report is 1 commits behind head on main.

Files	Patch %	Lines
internal/admission/validation/gateway/httproute.go	69.2%	9 Missing and 3 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##            main   #5469     +/-   ##
=======================================
- Coverage   69.8%   69.7%   -0.1%     
=======================================
  Files        176     176             
  Lines      22723   22661     -62     
=======================================
- Hits       15861   15812     -49     
+ Misses      5927    5917     -10     
+ Partials     935     932      -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[randmonkey]

Have we added the tests for verifying that the status of HTTPRoute is correctly set in those siturations?

[czeslavo]

Have we added the tests for verifying that the status of HTTPRoute is correctly set in those siturations?

Some of them were already there, some were added. I linked to test cases in the PR description.