feat: don't validate HTTPRoute for allowedRoutes and listeners in webhook #5469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Removes
HTTPRoute
validations from the admission webhook:All of these validations are already handled in the controller itself:
kubernetes-ingress-controller/internal/controllers/gateway/route_utils.go
Line 216 in 2e22a10
kubernetes-ingress-controller/internal/controllers/gateway/route_utils.go
Line 270 in 2e22a10
kubernetes-ingress-controller/internal/controllers/gateway/route_utils.go
Line 245 in 2e22a10
All of these are now tested as well (on the unit test level):
kubernetes-ingress-controller/internal/controllers/gateway/route_utils_test.go
Line 419 in 2e22a10
kubernetes-ingress-controller/internal/controllers/gateway/route_utils_test.go
Line 536 in cd74f82
kubernetes-ingress-controller/internal/controllers/gateway/route_utils_test.go
Line 555 in cd74f82
Which issue this PR fixes:
Fixes #5197.
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR