backport(3.1.x): fix(konnect) avoid collisions when redacting (#5964) #6001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/3.1.x #6001 +/- ##
===============================================
Coverage ? 72.0%
===============================================
Files ? 177
Lines ? 18313
Branches ? 0
===============================================
Hits ? 13201
Misses ? 4150
Partials ? 962 ☔ View full report in Codecov by Sentry. |
czeslavo
previously approved these changes
May 10, 2024
When generating sanitized configuration for Konnect, use random values to redact unique fields. Internally, go-database-reconciler builds an in-memory database with certain fields as primary keys. Using static redacted values for these results in collisions in that database. (cherry picked from commit 4b60bf8)
randmonkey
force-pushed
the
backport-5964-to-release/3.1.x
branch
from
45e3b4e
to
e612776
Compare
tao12345666333
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes:
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR